Remove check for no workers #3281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I *believe* this is actually safe, and the assert was errantly copy-pasted a while back. Fixes grpc#3022
|
Thanks! I will check if it helps and advise. |
|
Running the tests, it looks like I am mostly running into #3282, which doesn't seem to be related. Seems this fix works just fine. |
|
Do I need to bump the release tag to that ? How bad is it ? |
nicolasnoble
added a commit
that referenced
this pull request
Sep 8, 2015
Remove check for no workers
|
Probably worth bumping the tag On Tue, Sep 8, 2015 at 1:40 PM Nicolas Noble notifications@github.com
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this is actually safe, and the assert was errantly
copy-pasted a while back.
Fixes #3022
@jtattermusch - PTAL