[ruby] testing: Add ruby 3.0/3.1/3.2 unit tests #31991
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apolcyn
added
lang/ruby
release notes: no
grpc-checks
bot
added
per-call-memory/neutral
per-channel-memory/neutral
bloat/none
labels
apolcyn
changed the title
apolcyn
changed the title
|
This issue/PR has been automatically marked as stale because it has not had any update (including commits, comments, labels, milestones, etc) for 30 days. It will be closed automatically if no further update occurs in 7 day. Thank you for your contributions! |
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 17, 2024
#35399) Updates ruby-compiler-dock to 1.4.0 which brings Ruby 3.3 final support per https://github.com/rake-compiler/rake-compiler-dock/releases/tag/1.4.0 and starts cross-compiling for ruby 3.3. I can't find obviously where the test infrastructure configuration is to run the tests under Ruby 3.3, so might need pointers or an accompanying PR for the test infra. (I note #31991 from @apolcyn so perhaps currently they are not run against newer versions) Fixes #35396 - Backport to `1.60` is desirable since currently the Ruby gems cannot be installed with Ruby 3.3 and have to be built from source. Closes #35399 PiperOrigin-RevId: 599200628
chadlwilson
added a commit
to chadlwilson/grpc
that referenced
this pull request
Jan 18, 2024
grpc#35399) Updates ruby-compiler-dock to 1.4.0 which brings Ruby 3.3 final support per https://github.com/rake-compiler/rake-compiler-dock/releases/tag/1.4.0 and starts cross-compiling for ruby 3.3. I can't find obviously where the test infrastructure configuration is to run the tests under Ruby 3.3, so might need pointers or an accompanying PR for the test infra. (I note grpc#31991 from @apolcyn so perhaps currently they are not run against newer versions) Fixes grpc#35396 - Backport to `1.60` is desirable since currently the Ruby gems cannot be installed with Ruby 3.3 and have to be built from source. Closes grpc#35399 PiperOrigin-RevId: 599200628 (cherry picked from commit 43d2b28)
apolcyn
pushed a commit
to apolcyn/grpc
that referenced
this pull request
Jan 19, 2024
grpc#35399) Updates ruby-compiler-dock to 1.4.0 which brings Ruby 3.3 final support per https://github.com/rake-compiler/rake-compiler-dock/releases/tag/1.4.0 and starts cross-compiling for ruby 3.3. I can't find obviously where the test infrastructure configuration is to run the tests under Ruby 3.3, so might need pointers or an accompanying PR for the test infra. (I note grpc#31991 from @apolcyn so perhaps currently they are not run against newer versions) Fixes grpc#35396 - Backport to `1.60` is desirable since currently the Ruby gems cannot be installed with Ruby 3.3 and have to be built from source. Closes grpc#35399 PiperOrigin-RevId: 599200628
apolcyn
added a commit
that referenced
this pull request
Jan 19, 2024
…3.3 support (#35399)" (#35614) Updates ruby-compiler-dock to 1.4.0 which brings Ruby 3.3 final support per https://github.com/rake-compiler/rake-compiler-dock/releases/tag/1.4.0 and starts cross-compiling for ruby 3.3. I can't find obviously where the test infrastructure configuration is to run the tests under Ruby 3.3, so might need pointers or an accompanying PR for the test infra. (I note #31991 from @apolcyn so perhaps currently they are not run against newer versions) Fixes #35396 - Backport to `1.60` is desirable since currently the Ruby gems cannot be installed with Ruby 3.3 and have to be built from source. Closes #35399 PiperOrigin-RevId: 599200628 <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Co-authored-by: Chad Wilson <chadw@thoughtworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ruby version as a dimension on the unit test matrix, and add coverage for ruby 3.0, 3.1, and ruby 3.2 which is newly released.
So far, we've had CI coverage for all supported ruby versions via the simple package distrib tests. This PR adds more comprehensive testing by running the full unit test suite on each ruby version - which has been a gap in our test coverage so far.
Passing run from a manual invocation of
grpc_portabilityoff this PR: https://source.cloud.google.com/results/invocations/dac0373c-12ca-4170-b378-c60d24bcf481/targetsNote:
ruby version is plumbed through
run_tests.pyas a type of compiler. This seemed convenient because we need to compile separate grpc-ruby binaries for different ruby versions anyways, i.e. we need separate build phases for each one.Basic tests Rubystill tests only the oldest supported ruby version (ruby 2.7 for now). The other ruby versions are tested in the portability job running on master. We could have added them to the basic tests ruby job, but that would noticeably increase the runtime of the job (earlier attempts to do so caused timeouts so we would need to raise the timeout, for example).