Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flow control issues #3190

Merged
merged 12 commits into from
Sep 3, 2015
Merged

Fix flow control issues #3190

merged 12 commits into from
Sep 3, 2015

Conversation

ctiller
Copy link
Member

@ctiller ctiller commented Sep 2, 2015

#3088 against 0.11

rni-gc and others added 10 commits August 26, 2015 16:38
This is a repro case for a bug where if the client is sending
full throttle and the receiver is not able to keep up, the
client reaches a case where it doesn't make forward progress
anymore.

Signed-off-by: Craig Tiller <craig.tiller@gmail.com>
If we get a full incoming buffer, we'll issue a read with max_recv_bytes==0, deadlocking the flow control code.
Instead, hold off on advertising reading until the buffer gets a little more clear, then start pulling.
Conflicts:
	build.json
	vsprojects/Grpc.mak
@yang-g
Copy link
Member

yang-g commented Sep 2, 2015

LGTM. Seems sanity is failing.

@ctiller
Copy link
Member Author

ctiller commented Sep 2, 2015

Sanity will be passing with #3183 - it's actually nothing to do with this PR.

@ctiller
Copy link
Member Author

ctiller commented Sep 3, 2015

ping

yang-g added a commit that referenced this pull request Sep 3, 2015
@yang-g yang-g merged commit 2b5255e into grpc:release-0_11 Sep 3, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Jan 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants