-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flow control issues #3190
Merged
Merged
Fix flow control issues #3190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a repro case for a bug where if the client is sending full throttle and the receiver is not able to keep up, the client reaches a case where it doesn't make forward progress anymore. Signed-off-by: Craig Tiller <craig.tiller@gmail.com>
If we get a full incoming buffer, we'll issue a read with max_recv_bytes==0, deadlocking the flow control code. Instead, hold off on advertising reading until the buffer gets a little more clear, then start pulling.
Conflicts: build.json vsprojects/Grpc.mak
LGTM. Seems sanity is failing. |
Sanity will be passing with #3183 - it's actually nothing to do with this PR. |
ping |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3088 against 0.11