Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor fixes to string_ref #3094

Merged
merged 1 commit into from
Aug 27, 2015
Merged

minor fixes to string_ref #3094

merged 1 commit into from
Aug 27, 2015

Conversation

yang-g
Copy link
Member

@yang-g yang-g commented Aug 27, 2015

  • header guard format
  • add comment on constexpr
  • remove lambda
  • remove range based loop in test

The latter two fix #3091.

@yang-g yang-g added this to the Beta milestone Aug 27, 2015
jboeuf added a commit that referenced this pull request Aug 27, 2015
@jboeuf
Merge pull request #3094 from yang-g/string_ref_auth
15df9b1 
minor fixes to string_ref
@jboeuf jboeuf merged commit 15df9b1 into grpc:master Aug 27, 2015
@jboeuf
Copy link
Contributor

jboeuf commented Aug 27, 2015

Thanks much for the fixes.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@jboeuf jboeuf

Labels
cla: yes lang/c++
Projects
None yet
Milestone
Beta
Development

Successfully merging this pull request may close these issues.

GCC 4.4.7 compile error in src/cpp/util/string_ref.cc
3 participants
@yang-g @jboeuf @googlebot