Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php: fixed constant typo #2961

Merged
merged 1 commit into from
Aug 17, 2015
Merged

php: fixed constant typo #2961

merged 1 commit into from
Aug 17, 2015

Conversation

stanley-cheung
Copy link
Contributor

bug fix for #2877.

We should add a test for waitForReady, but that may involve changing the code generator.

@stanley-cheung stanley-cheung added this to the Beta milestone Aug 17, 2015
murgatroid99 added a commit that referenced this pull request Aug 17, 2015
@murgatroid99
Merge pull request #2961 from stanley-cheung/php_waitforready
6de6cbf 
php: fixed constant typo
@murgatroid99 murgatroid99 merged commit 6de6cbf into grpc:master Aug 17, 2015
@stanley-cheung stanley-cheung deleted the php_waitforready branch August 17, 2015 22:08
@lock lock bot locked as resolved and limited conversation to collaborators Jan 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@murgatroid99 murgatroid99

Labels
cla: yes lang/all wrapped languages lang/php
Projects
None yet
Milestone
Beta
Development

Successfully merging this pull request may close these issues.
3 participants
@stanley-cheung @murgatroid99 @googlebot