[PSM interop] Expand the support of test config validation #28978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidizheng
added
area/test
release notes: no
|
Re-triggered on March 1st: |
grpc-checks
bot
added
perf-change/improvement
perf-change/none
perf-change/high
and removed
perf-change/improvement
perf-change/none
labels
lidizheng
force-pushed
the
skip-in-master
branch
from
58e9420 to
704b3e3
Compare
gnossen
approved these changes
Mar 2, 2022
| @@ -101,6 +101,7 @@ run_test() { | |||
| --secondary_kube_context="${SECONDARY_KUBE_CONTEXT}" \ | |||
| --server_image="${SERVER_IMAGE_NAME}:${GIT_COMMIT}" \ | |||
| --client_image="${CLIENT_IMAGE_NAME}:${GIT_COMMIT}" \ | |||
| --testing_version=$(echo "$KOKORO_JOB_NAME" | sed -E 's|^grpc/core/([^/]+)/.*|\1|') \ | |||
There was a problem hiding this comment.
Please add a comment explaining what's going on here.
There was a problem hiding this comment.
Thanks for the quick reivew!
Comment added to all 7 Kokoro script. It explains how the version is fetched, and why we need it.
copybara-service
bot
added
the
imported
sergiitk
added a commit
that referenced
this pull request
Jun 7, 2022
1. Fixes the issue with Java PSM security tests accidentally skipped because Java was missing from the list of languages, ref #28978 2. Invert the logic of `is_supported` methods, making them normally open 3. Make languages an `enum.Flag` to avoid accidental typos when listing the languages 4. Rename `XdsKubernetesTestCase.isSupported` to `XdsKubernetesTestCase.is_supported` to be consistent with `XdsUrlMapTestCase.is_supported` 5. Add extra logging
sergiitk
added a commit
to grpc/psm-interop
that referenced
this pull request
Nov 8, 2023
1. Fixes the issue with Java PSM security tests accidentally skipped because Java was missing from the list of languages, ref grpc/grpc#28978 2. Invert the logic of `is_supported` methods, making them normally open 3. Make languages an `enum.Flag` to avoid accidental typos when listing the languages 4. Rename `XdsKubernetesTestCase.isSupported` to `XdsKubernetesTestCase.is_supported` to be consistent with `XdsUrlMapTestCase.is_supported` 5. Add extra logging
sergiitk
pushed a commit
to sergiitk/grpc
that referenced
this pull request
Dec 8, 2023
* [PSM interop] Expand the support of test config validation * Comment the usage and source of testing_version * Also include the comment for url-map tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For non-url-map PSM GKE tests, we didn't have a mechanism to skip a test case, if a specific gRPC release don't support the testing test case. This wasn't an issue because we hard coded the skip logic in both production and staging. This PR unifies the skip implementation in production/staging (with its google3 counterpart, this PR needs to go in first), all flavors of GKE tests.
This PR also updates the supported gRPC versions for each test case (based on https://github.com/grpc/grpc/blob/master/doc/grpc_xds_features.md).
(This PR unblocks adding older branches to the GKE tests family.)