Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch run_xds_tests.py shebang to python3 #28964

Merged
merged 1 commit into from
Feb 25, 2022
Merged

Switch run_xds_tests.py shebang to python3 #28964

merged 1 commit into from
Feb 25, 2022

Conversation

jtattermusch
Copy link
Contributor

Same as #28963, but updates the run_xds_tests.py script.
Since it touches the PSM interop tests, I wanted to have a separate change to avoid accidentally breaking stuff.

  • it would be useful if we had some presubmit tests for xds interop, since currently the tests are both fragile AND we don't run them on presubmit. Of course to do that we'd need to make sure the tests are compatible with running on PRs from from the perspective of hermeticity and speed (they'd need to take less than 30mins).

@jtattermusch jtattermusch requested a review from gnossen February 24, 2022 08:09
@jtattermusch jtattermusch added the release notes: no Indicates if PR should not be in release notes label Feb 24, 2022
@gnossen
Copy link
Contributor

gnossen commented Feb 24, 2022

The tests are already running under Python 3. This PR should be a no-op.

@jtattermusch
Copy link
Contributor Author

@sergiitk @lidizheng feel free to merge once you're happy with this PR.

lidizheng
lidizheng approved these changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@lidizheng lidizheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as Richard mentioned. It's already using Python3.

@jtattermusch jtattermusch merged commit c05ecb8 into grpc:master Feb 25, 2022
@copybara-service copybara-service bot added the imported Specifies if the PR has been imported to the internal repository label Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidizheng lidizheng lidizheng approved these changes

@gnossen gnossen gnossen approved these changes

@sergiitk sergiitk Awaiting requested review from sergiitk

Assignees

@sergiitk sergiitk

Labels
bloat/none imported Specifies if the PR has been imported to the internal repository perf-change/none release notes: no Indicates if PR should not be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jtattermusch @gnossen @lidizheng @sergiitk