Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

retry: fix memory leak due to not freeing cached send ops upon cancellation #28945

Merged
merged 3 commits into from
Feb 23, 2022
Merged

retry: fix memory leak due to not freeing cached send ops upon cancellation #28945

merged 3 commits into from
Feb 23, 2022

Conversation

markdroth
Copy link
Member

Missed this in #28913.

@markdroth markdroth added the release notes: no Indicates if PR should not be in release notes label Feb 22, 2022
@markdroth markdroth requested a review from ctiller February 22, 2022 23:28
@markdroth markdroth merged commit f48c4f1 into grpc:master Feb 23, 2022
@markdroth markdroth mentioned this pull request Feb 23, 2022
Merged
markdroth added a commit that referenced this pull request Feb 23, 2022
@markdroth
Revert "retry: fix memory leak due to not freeing cached send ops upo…
755ebf8 
…n cancellation (#28945)"

This reverts commit f48c4f1.
@markdroth markdroth mentioned this pull request Feb 23, 2022
Merged
ctiller pushed a commit that referenced this pull request Feb 23, 2022
@markdroth
Revert "retry: fix memory leak due to not freeing cached send ops upo…
9498843 
…n cancellation (#28945)" (#28954)

This reverts commit f48c4f1.
@copybara-service copybara-service bot added the imported Specifies if the PR has been imported to the internal repository label Feb 23, 2022
markdroth added a commit to markdroth/grpc that referenced this pull request Feb 23, 2022
@markdroth
Revert "Revert "retry: fix memory leak due to not freeing cached send…
d70eea9 
… ops upon cancellation (grpc#28945)" (grpc#28954)"

This reverts commit 9498843.
markdroth added a commit that referenced this pull request Feb 24, 2022
@markdroth
retry: always free cached send op data (#28956)
3d4433b 
* Revert "Revert "retry: fix memory leak due to not freeing cached send ops upon cancellation (#28945)" (#28954)"

This reverts commit 9498843.

* retry: always free cached send op data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctiller ctiller ctiller approved these changes

Assignees
No one assigned
Labels
bloat/none imported Specifies if the PR has been imported to the internal repository lang/core perf-change/none release notes: no Indicates if PR should not be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markdroth @ctiller