Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change clone command to make it easier to pin test-infra version. #28941

Merged
merged 3 commits into from
Feb 28, 2022
Merged

Change clone command to make it easier to pin test-infra version. #28941

merged 3 commits into from
Feb 28, 2022

Conversation

paulosjca
Copy link
Contributor

@paulosjca paulosjca commented Feb 22, 2022 •
edited
Loading

Changed clone and checkout command to print checked-out version:

+ pushd ..
/tmpfs/src/github /tmpfs/src/github/grpc
+ git clone https://github.com/grpc/test-infra.git
Cloning into 'test-infra'...
+ cd test-infra
+ git checkout --detach
HEAD is now at 361ac97 Pin driver version (#277)

With these commands, we can check out a specific version by changing only one line in the script. For instance:

git checkout --detach v1.0.0

@paulosjca paulosjca added the release notes: no Indicates if PR should not be in release notes label Feb 22, 2022
jtattermusch
jtattermusch approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@jtattermusch jtattermusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as you're willing to keep an eye on updating the pinned version over time.

@paulosjca paulosjca changed the title Pin test-infra version to v1.0.0. Change clone command to make it easier to pin test-infra version. Feb 28, 2022
@paulosjca
Copy link
Contributor Author

LGTM as long as you're willing to keep an eye on updating the pinned version over time.

Since we don't have a problem that requires pinning now, just changing the command so it is easier to do in the future. Updated PR comment accordingly.

@paulosjca paulosjca enabled auto-merge (squash) February 28, 2022 20:49
@paulosjca paulosjca merged commit 4239060 into grpc:master Feb 28, 2022
@copybara-service copybara-service bot added the imported Specifies if the PR has been imported to the internal repository label Mar 1, 2022
@paulosjca paulosjca deleted the pintestinfra branch March 5, 2022 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtattermusch jtattermusch jtattermusch approved these changes

@ybbbby ybbbby Awaiting requested review from ybbbby

@wanlin31 wanlin31 Awaiting requested review from wanlin31

Assignees

@paulosjca paulosjca

@jtattermusch jtattermusch

Labels
bloat/none imported Specifies if the PR has been imported to the internal repository perf-change/none release notes: no Indicates if PR should not be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulosjca @jtattermusch