call grpc_init for GoogleDefaultCredentials #2879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #2290 |
| @@ -61,6 +62,7 @@ std::shared_ptr<Credentials> WrapCredentials(grpc_credentials* creds) { | |||
| } // namespace | |||
|
|
|||
| std::shared_ptr<Credentials> GoogleDefaultCredentials() { | |||
| GrpcLibrary init; // To call grpc_init(). | |||
There was a problem hiding this comment.
Shouldn't we do that in grpc_google_default_credentials_create instead? What happens if we just use the C API?
There was a problem hiding this comment.
From https://github.com/grpc/grpc/blob/master/include/grpc/grpc.h#L378, it seems we should do it in the C++ layer. Maybe even add it to all the XXCredentials() functions just to be safe?
There was a problem hiding this comment.
oh I see. you're right because C callers have to already call grpc_init explicitly. Sorry about that.
Now I agree with you that every entry point in the Cpp layer where this is not called should be fixed.
There was a problem hiding this comment.
Done for all secure credentials.
|
LGTM. Will merge when jenkins is greenish. |
jboeuf
added a commit
that referenced
this pull request
Aug 11, 2015
call grpc_init for GoogleDefaultCredentials
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The grpc_google_default_credentials_create call assumes grpc_init has been called, or it will crash if hit the gce detection part. Our C++ wrapper call grpc_init when a Credentials object is created and thus is too late.
I think default credentials is the only one with the problems as all others have trivial create() calls.