Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run_tests_matrix.py: run workspace jobs with python3 #28125

Merged

Conversation

jtattermusch
Copy link
Contributor

@jtattermusch jtattermusch commented Nov 18, 2021

Another of the place where python2->python3 didn't happen.

Followup for
#28010

@jtattermusch
Copy link
Contributor Author

@gnossen when run_tests.py is actually run with python3, the "Basic Tests Python MacOS" fails:

See:
https://source.cloud.google.com/results/invocations/2173b760-fb9b-4f75-be0d-ab1aa39627b4/targets

@jtattermusch jtattermusch force-pushed the run_tests_matrix_workspace_jobs branch 2 times, most recently from 1975533 to e2d7225 Compare December 1, 2021 13:58
@jtattermusch jtattermusch added the release notes: no Indicates if PR should not be in release notes label Dec 1, 2021
@jtattermusch jtattermusch marked this pull request as ready for review December 1, 2021 13:59
@jtattermusch
Copy link
Contributor Author

@gnossen we should merge this eventually (once you figure out the problem with python macOS job mentioned in #28125 (comment)

Copy link
Contributor

@gnossen gnossen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll keep you updated as I debug the MacOS issue.

@jtattermusch
Copy link
Contributor Author

jtattermusch commented Feb 24, 2022

I'll keep you updated as I debug the MacOS issue.

@gnossen any progress on this?

@jtattermusch jtattermusch force-pushed the run_tests_matrix_workspace_jobs branch from e2d7225 to 692e40f Compare March 14, 2022 09:44
@jtattermusch
Copy link
Contributor Author

This should be now unblocked since #28963 was merged.
I rebased and I'll merge once the tests are green.

1 similar comment
@jtattermusch
Copy link
Contributor Author

This should be now unblocked since #28963 was merged.
I rebased and I'll merge once the tests are green.

@jtattermusch
Copy link
Contributor Author

Known failures:

  • interop node build is broken on master as well.

@jtattermusch jtattermusch merged commit 6f75e54 into grpc:master Mar 14, 2022
@copybara-service copybara-service bot added the imported Specifies if the PR has been imported to the internal repository label Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bloat/none imported Specifies if the PR has been imported to the internal repository per-call-memory/neutral perf-change/none release notes: no Indicates if PR should not be in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants