C# Improving Channel API #2756
Merged
C# Improving Channel API #2756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, looks flaky. |
|
In tests, for channels where you set the channel argument |
| { | ||
| using (var channel = new Channel("127.0.0.1", Credentials.Insecure)) | ||
| { | ||
| Assert.IsTrue(channel.Target.Contains("127.0.0.1")); |
There was a problem hiding this comment.
The actual value of the channel target is not guaranteed.
There was a problem hiding this comment.
Seems it's working reliably on my machine and in our test environment. Do you still suggest removing?
jtattermusch
force-pushed
the
csharp_channel_state
branch
from
34c612d to
541768e
Compare
|
Why is grpc.default_authority important? Looks like none of gRPC implementations is setting it. |
|
MIchael is OOO, I will discuss the grpc.default_authority with him separately. Please review the rest of the code. |
jtattermusch
force-pushed
the
csharp_channel_state
branch
from
dfea902 to
9fb1d20
Compare
|
Didn't see anything that jumps out to me. LGTM. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- add channel state API
-- start using default host when calling grpc_channel_create_call
-- add some tests
-- fix some style nits
-- exposes Target property for channel with the right contents.
Fixes #2508
Fixes #2637