The committers are authorized under a signed CLA.

• ✅ Anthony Bellissimo (c4ab85d)

Looks good. TIL windows allow special chars like \ in filename.

In Windows, backslash is the path separator! I actually used forward-slashes in my project config, but something converted it into its platform-native representation before this code encountered it.

@twon33 Right, my bad. I was reading from a wrong source: https://awp.autotask.net/help/Content/1_GENERAL/File_Name_Constraints.htm

According to wiki, \ is prohibited as filenames on Windows https://en.wikipedia.org/wiki/Filename.

Known failure #26595

Could we get this into the next patch release? It looks like 1.39.0 and 1.39.1 were both released after this PR but didn't include this commit, and this is currently blocking our gRPC upgrade since our Windows build fails on any gRPC versions on or after 1.27.0 (which is the first release that included the header detection changes).

@clarkzinzow The v1.40.0 release is on the way and includes this change. It should be happen soon.

CC @nicolasnoble for a more accurate release date.

@lidizheng Perfect, thank you! 😄 We're applying a manual patch via a Bazel HTTP archive target for now, but we'll be sure to upgrade to v1.40.0 once it's out and remove the patch.