Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linuxbrew testing to jenkins #2367

Merged
merged 2 commits into from
Jul 10, 2015

Conversation

stanley-cheung
Copy link
Contributor

For issue #1883

# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
#
# This script is invoked by Jenkins and triggers a test run based on
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the comment

@jtattermusch
Copy link
Contributor

Come on guys, just go to sleep, it's 1AM. :-)

@stanley-cheung
Copy link
Contributor Author

Thanks for the feedback guys :) Will update the PR.

@stanley-cheung stanley-cheung force-pushed the add_homebrew_to_jenkins branch from fc03cfc to 1ad5ea5 Compare July 10, 2015 23:08

supported="python nodejs ruby php"

if [ "$language" == "core" ]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on jenkins, then language is called "c"
https://grpc-testing.appspot.com/job/gRPC_master/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, I take it back, I will setup the jenkins job to use these constants for now.

@jtattermusch
Copy link
Contributor

Jenkins failures are clearly unrelated, merging this.

jtattermusch added a commit that referenced this pull request Jul 10, 2015
@jtattermusch jtattermusch merged commit 55d3d41 into grpc:master Jul 10, 2015
@stanley-cheung stanley-cheung changed the title Add homebrew testing to jenkins Add linuxbrew testing to jenkins Jul 20, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Jan 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants