Support registering services against specific hosts #2320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ruby flake should be unrelated; Jenkins green. |
| void RegisterService(const grpc::string& host, | ||
| SynchronousService* service); | ||
|
|
||
| // Register an asynchronous service. New calls will be delevered to cq. |
There was a problem hiding this comment.
The comment is stale (as that of the other function).
|
LGTM otherwise |
| typedef std::unique_ptr<grpc::string> HostString; | ||
| template <class T> struct NamedService { | ||
| explicit NamedService(T* s) : service(s) {} | ||
| explicit NamedService(const grpc::string& h, T *s) |
There was a problem hiding this comment.
Updated based on feedback
On Tue, Jul 7, 2015 at 10:44 PM Yang Gao notifications@github.com wrote:
In include/grpc++/server_builder.h
#2320 (comment):@@ -98,9 +111,18 @@ class ServerBuilder {
int* selected_port;
};
- typedef std::unique_ptrgrpc::string HostString;
- template struct NamedService {
- explicit NamedService(T* s) : service(s) {}
- explicit NamedService(const grpc::string& h, T *s)
This does not need explicit?
—
Reply to this email directly or view it on GitHub
https://github.com/grpc/grpc/pull/2320/files#r34117367.
yang-g
added a commit
that referenced
this pull request
Jul 9, 2015
Support registering services against specific hosts
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2058
Fixes #2055