Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify metadata usage #2051

Merged
merged 8 commits into from
Jun 15, 2015
Merged

Conversation

jcanizales
Copy link
Contributor

Issues found when implementing grpc/grpc-experiments#243.

  • Lets set an immutable dictionary.
  • Lets just set single headers without checking first if the dictionary is nil.
  • Surfaces trailers.
  • Puts response metadata into NSError.
  • Drops duplicate response metadata so users don't have to write call.responseMetadata[@"my-header"][0] in the common case.
  • Adds metadata unit tests.
  • Fixes specification in GRPCCall.h.

I think in the process we might have gotten rid of a race condition for setting the response headers.

murgatroid99 added a commit that referenced this pull request Jun 15, 2015
@murgatroid99 murgatroid99 merged commit e8d55cf into grpc:master Jun 15, 2015
@jcanizales jcanizales deleted the simplify-metadata branch June 16, 2015 00:26
@lock lock bot locked as resolved and limited conversation to collaborators Jan 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants