Revised the state machine. #2046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| large amounts of time in this state. | ||
|
|
||
| IDLE: This is the state where the channel is not even trying to create a | ||
| connection because of a lack of new or pending RPCs. New channels MAY be created |
There was a problem hiding this comment.
Could we have a definition of a "pending RPC"? Is it a synonym of active RPC? What is an active RPC?
There was a problem hiding this comment.
Synonyms. An active/pending RPC is one that has been started but has not finshed (returned status). This is from the channel's perspective, so if the channel is wrapped by something and that wrapper buffers RPCs, those buffered RPCs will be active at the wrapper but not at the channel.
|
Updated the spelling of GO_AWAY to GOAWAY and responded to questions. PTAL. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an IDLE state and replaced FATAL_FAILURE with shutdown. Also modified come phrasing for TRANSIENT_FAILURE for clarity.