Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add abseil to gRPC Core #20184

Merged
merged 1 commit into from
Jan 4, 2020
Merged

Add abseil to gRPC Core #20184

merged 1 commit into from
Jan 4, 2020

Conversation

veblush
Copy link
Contributor

@veblush veblush commented Sep 5, 2019 •
edited
Loading

TL;DR Abseil is now integrated into gRPC Core.

Code changes:

  • Set GRPC_USE_ABSL = 1
    • Activating absl::string_view instead of gRPC StringView
    • Activating absl::InlinedVector instead of gRPC InlinedVector
  • Adding TODO to grpc_core::Optional on migration to absl::optional

Build pipeline changes:

  • Makefile (with grpc_abseil)
  • CMake (+ various scenario & test)
  • PHP support
  • Python support
  • Ruby support
  • Xcode podspec support

Test:

@veblush veblush added release notes: no Indicates if PR should not be in release notes area/core labels Sep 5, 2019
@veblush veblush changed the title Add abseil Add abseil to gRPC Core Sep 5, 2019
@veblush veblush force-pushed the try-abseil branch 16 times, most recently from 7895192 to 11ced0b Compare September 10, 2019 15:27
@veblush veblush force-pushed the try-abseil branch 4 times, most recently from c597da4 to d1cb951 Compare October 11, 2019 00:04
@veblush veblush force-pushed the try-abseil branch 4 times, most recently from b329106 to 0dd6787 Compare October 29, 2019 18:50
@veblush veblush mentioned this pull request Nov 1, 2019
Merged
@veblush veblush force-pushed the try-abseil branch 3 times, most recently from 3cdfbce to 3cf5b50 Compare December 17, 2019 18:28
@veblush veblush mentioned this pull request Dec 17, 2019
Merged
This was referenced Dec 18, 2019
Merged
Merged
@veblush veblush marked this pull request as ready for review December 19, 2019 03:29
This was referenced Dec 19, 2019
Merged
Merged
@veblush veblush force-pushed the try-abseil branch 2 times, most recently from 92cf04f to 9f84983 Compare December 23, 2019 16:32
@veblush veblush mentioned this pull request Jan 2, 2020
Merged
nicolasnoble
nicolasnoble approved these changes Jan 3, 2020
View reviewed changes
Copy link
Member

@nicolasnoble nicolasnoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minus the small requested change.

@veblush
Copy link
Contributor Author

veblush commented Jan 4, 2020

Thanks, Nico!

@veblush veblush merged commit 40d8986 into grpc:master Jan 4, 2020
@veblush veblush deleted the try-abseil branch January 4, 2020 06:18
This was referenced Jan 7, 2020
Merged
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nicolasnoble nicolasnoble nicolasnoble approved these changes

@apolcyn apolcyn Awaiting requested review from apolcyn apolcyn is a code owner

@gnossen gnossen Awaiting requested review from gnossen gnossen is a code owner

@jtattermusch jtattermusch Awaiting requested review from jtattermusch

Assignees
No one assigned
Labels
area/core release notes: no Indicates if PR should not be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@veblush @nicolasnoble