Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix C# test access violation exception on Windows #1941

Merged
merged 1 commit into from
Jun 4, 2015

Conversation

jtattermusch
Copy link
Contributor

fix wrong ordering of free and iomgr_unregister_object
Fixes #1940

@nicolasnoble FYI

ctiller added a commit that referenced this pull request Jun 4, 2015
Fix C# test access violation exception on Windows
@ctiller ctiller merged commit 3e50a65 into grpc:master Jun 4, 2015
@jtattermusch
Copy link
Contributor Author

Look at the wonderful blue dot this merge has added to the csharp-windows cell on Jenkins.
http://grpc-testing.appspot.com/job/gRPC/27/ (it was red before)

@ctiller
Copy link
Member

ctiller commented Jun 4, 2015

I like http://green.bikeshed.org better than http://blue.bikeshed.org.

On Thu, Jun 4, 2015 at 2:04 PM Jan Tattermusch notifications@github.com
wrote:

Look at the wonderful blue dot this merge has added to the csharp-windows
cell on Jenkins.
http://grpc-testing.appspot.com/job/gRPC/27/ (it was red before)


Reply to this email directly or view it on GitHub
#1941 (comment).

@jtattermusch
Copy link
Contributor Author

Better now?

@ctiller
Copy link
Member

ctiller commented Jun 4, 2015

\o/

On Thu, Jun 4, 2015 at 3:00 PM Jan Tattermusch notifications@github.com
wrote:

Better now?


Reply to this email directly or view it on GitHub
#1941 (comment).

@lock lock bot locked as resolved and limited conversation to collaborators Jan 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Labeling iomgr objects makes C# tests crash
3 participants