Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gRPC.podspec to pass pod spec lint #1939

Merged
merged 1 commit into from
Jun 4, 2015
Merged

Fix gRPC.podspec to pass pod spec lint #1939

merged 1 commit into from
Jun 4, 2015

Conversation

jcanizales
Copy link
Contributor

  • Relax protobuf requirement to alpha version. (One of a few fixes needed for Podspecs cannot yet depend on Protobuf ~> 3.0 #1899)
  • Suppress warnings for GRPCClient.
  • Fix headers search path.
  • Subspecs can't have summaries, so turn into comments.
  • Document hacks.

@jcanizales
Fix gRPC.podspec to pass pod spec lint
461b094 
- Relax protobuf requirement to alpha version
- Suppress warnings for GRPCClient
- Fix headers search path
- Document hacks.
murgatroid99
murgatroid99 reviewed Jun 4, 2015
View reviewed changes
gRPC.podspec
ps.source_files = 'src/objective-c/ProtoRPC/*.{h,m}'

ps.dependency 'gRPC/GRPCClient'
ps.dependency 'gRPC/RxLibrary'
ps.dependency 'Protobuf', '~> 3.0'
ps.dependency 'Protobuf', '~> 3.0.0-alpha-3'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also change this in the example in the README?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sending that on another PR, as I'm also simplifying things for Cocoapods users by invoking protoc in the podspec, as part of pod install (so it needs rewording).

murgatroid99 added a commit that referenced this pull request Jun 4, 2015
@murgatroid99
Merge pull request #1939 from jcanizales/podspec-that-passes-lint
7faeea5 
Fix gRPC.podspec to pass pod spec lint
@murgatroid99 murgatroid99 merged commit 7faeea5 into grpc:master Jun 4, 2015
@jcanizales jcanizales deleted the podspec-that-passes-lint branch June 5, 2015 00:38
@lock lock bot locked as resolved and limited conversation to collaborators Jan 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@murgatroid99 murgatroid99

Labels
cla: yes lang/all wrapped languages lang/ObjC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcanizales @murgatroid99 @googlebot