Fix version number of gRPC.podspec #1876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And solves a few linter issues that prevent it from being submitted to Cocoapods' repo.
| cs.xcconfig = { 'HEADER_SEARCH_PATHS' => '"$(PODS_ROOT)/Headers/Build/gRPC" "$(PODS_ROOT)/Headers/Build/gRPC/include"' } | ||
| cs.xcconfig = { 'HEADER_SEARCH_PATHS' => '"$(PODS_ROOT)/Headers/Build/gRPC" ' | ||
| '"$(PODS_ROOT)/Headers/Build/gRPC/include"' } | ||
| cs.compiler_flags = '-GCC_WARN_INHIBIT_ALL_WARNINGS', '-w' |
There was a problem hiding this comment.
This kind of seems like a bad idea. Why are we suppressing warnings now?
There was a problem hiding this comment.
Cocoapods' linter won't accept a submission with warnings :(
An alternative is to leave it out and only add it for actually submitting the spec. Same as with the commented-out s.source line. On the other hand, those dozens of warnings have been there forever and we still haven't added issues to get them fixed.
There was a problem hiding this comment.
For now I think what you have is probably better than adding it only for submission. But we should have issues for fixing those warnings.
There was a problem hiding this comment.
Ack. Added an A.I. on my calendar for later this week.
murgatroid99
added a commit
that referenced
this pull request
Jun 2, 2015
Fix version number of gRPC.podspec
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And solves a few linter issues that prevent it from being submitted to Cocoapods' repo.