Removed grpc_byte_buffer_reader_{create,destroy}. #1866
Conversation
Introduced grpc_byte_buffer_init instead. It's now the user's responsibility to manage memory.
| /* At the end of the stream, returns 0. Otherwise, returns 1 and sets slice to | ||
| be the returned slice. Caller is responsible for calling gpr_slice_unref on | ||
| the result. */ | ||
| int grpc_byte_buffer_reader_next(grpc_byte_buffer_reader *reader, | ||
| gpr_slice *slice); | ||
| void grpc_byte_buffer_reader_destroy(grpc_byte_buffer_reader *reader); |
There was a problem hiding this comment.
It might be worth keeping this API, even as a no-op for now.
What happens if we need to allocate some memory in order to read the byte buffer?
(for instance: decompressing it into a temporary slice buffer?)
There was a problem hiding this comment.
The idea being to encapsulate the creation/destruction, as opposed to having the user gpr_malloc+grpc_bb_reader_init / gpr_free "in the open"?
There was a problem hiding this comment.
Right... so:
grpc_byte_buffer_reader r;
grpc_byte_buffer_reader_init(&r, ...);
// do some wonderful things
grpc_byte_buffer_reader_destroy(&r);
On Mon, Jun 1, 2015 at 9:51 PM David G. Quintas notifications@github.com
wrote:
In include/grpc/grpc.h
#1866 (comment):/* At the end of the stream, returns 0. Otherwise, returns 1 and sets slice to
be the returned slice. Caller is responsible for calling gpr_slice_unref on
the result. */
int grpc_byte_buffer_reader_next(grpc_byte_buffer_reader *reader,
gpr_slice *slice);
-void grpc_byte_buffer_reader_destroy(grpc_byte_buffer_reader *reader);The idea being to encapsulate the creation/destruction, as opposed to
having the user gpr_{malloc,free} "in the open"?—
Reply to this email directly or view it on GitHub
https://github.com/grpc/grpc/pull/1866/files#r31492707.
|
Node failure is possibly unrelated to the change, independently reported in #1867 |
As a no-op for the time being.
|
Comments addressed. |
| gpr_slice next; | ||
| while (grpc_byte_buffer_reader_next(reader, &next) != 0) { | ||
| while (grpc_byte_buffer_reader_next(&reader, &next) != 0) { | ||
| memcpy(result + offset, GPR_SLICE_START_PTR(next), GPR_SLICE_LENGTH(next)); | ||
| offset += GPR_SLICE_LENGTH(next); | ||
| } |
There was a problem hiding this comment.
It looks like there used to be a leak here: no mention of grpc_byte_buffer_reader_destroy
Removed grpc_byte_buffer_reader_{create,destroy}.
Introduced grpc_byte_buffer_init instead. It's now the user's responsibility to manage memory.