-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V1.19.x #18301
V1.19.x #18301
Conversation
@@ -23,15 +23,15 @@ | |||
Pod::Spec.new do |s| | |||
s.name = 'gRPC-C++' | |||
# TODO (mxyan): use version that match gRPC version when pod is stabilized | |||
# version = '1.19.0' | |||
# version = '1.19.1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: looks like we are already using grpc_version so this line and the previous comment line should be removed (and the generation script modified not to look for this)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @muxi
This can be resolved in master for next release.
<release>1.19.0</release> | ||
<api>1.19.0</api> | ||
<release>1.19.1</release> | ||
<api>1.19.1</api> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stanley-cheung do you know why we are updating both the api and release versions? If the api has not changed, we should not bump it up, right? Not a big issue for this PR though...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea I will make a note of these and fix it in master
. But this api
version doesn't really matter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it mean it can be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That I am not sure, there's a format for these PECL extension.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
patch release