V1.19.x #18301
V1.19.x #18301
Conversation
srini100
added
the
release notes: no
| @@ -23,15 +23,15 @@ | |||
| Pod::Spec.new do |s| | |||
| s.name = 'gRPC-C++' | |||
| # TODO (mxyan): use version that match gRPC version when pod is stabilized | |||
| # version = '1.19.0' | |||
| # version = '1.19.1' | |||
There was a problem hiding this comment.
Nit: looks like we are already using grpc_version so this line and the previous comment line should be removed (and the generation script modified not to look for this)
There was a problem hiding this comment.
cc @muxi
This can be resolved in master for next release.
| <release>1.19.0</release> | ||
| <api>1.19.0</api> | ||
| <release>1.19.1</release> | ||
| <api>1.19.1</api> |
There was a problem hiding this comment.
@stanley-cheung do you know why we are updating both the api and release versions? If the api has not changed, we should not bump it up, right? Not a big issue for this PR though...
There was a problem hiding this comment.
Yea I will make a note of these and fix it in master. But this api version doesn't really matter.
There was a problem hiding this comment.
Does it mean it can be removed?
There was a problem hiding this comment.
That I am not sure, there's a format for these PECL extension.
patch release