Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1.19.x #18301

Merged
merged 2 commits into from
Mar 8, 2019
Merged

V1.19.x #18301

merged 2 commits into from
Mar 8, 2019

Conversation

srini100
Copy link
Contributor

@srini100 srini100 commented Mar 8, 2019

patch release

@srini100 srini100 added the release notes: no Indicates if PR should not be in release notes label Mar 8, 2019
@srini100 srini100 requested a review from sanjaypujare March 8, 2019 19:51
@@ -23,15 +23,15 @@
Pod::Spec.new do |s|
s.name = 'gRPC-C++'
# TODO (mxyan): use version that match gRPC version when pod is stabilized
# version = '1.19.0'
# version = '1.19.1'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: looks like we are already using grpc_version so this line and the previous comment line should be removed (and the generation script modified not to look for this)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @muxi
This can be resolved in master for next release.

<release>1.19.0</release>
<api>1.19.0</api>
<release>1.19.1</release>
<api>1.19.1</api>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stanley-cheung do you know why we are updating both the api and release versions? If the api has not changed, we should not bump it up, right? Not a big issue for this PR though...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea I will make a note of these and fix it in master. But this api version doesn't really matter.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it mean it can be removed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That I am not sure, there's a format for these PECL extension.

Copy link
Contributor

@sanjaypujare sanjaypujare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srini100 srini100 merged commit 109c570 into grpc:v1.19.x Mar 8, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release notes: no Indicates if PR should not be in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants