Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warning #17707

Merged
merged 1 commit into from
Jan 27, 2019
Merged

Fix warning #17707

merged 1 commit into from
Jan 27, 2019

Conversation

kakshay21
Copy link
Contributor

@kakshay21 kakshay21 commented Jan 13, 2019 •
edited
Loading

This PR is trying to fix the below warning which I noticed while doing bazel build :all

INFO: From Compiling src/cpp/server/load_reporter/load_reporter_async_service_impl.cc:
src/cpp/server/load_reporter/load_reporter_async_service_impl.cc:220:54: warning: format specifies type 'unsigned long' but the argument has type 'uint64_t' (aka 'unsigned long long') [-Wformat]
          service_, load_balanced_hostname_.c_str(), load_report_interval_ms_,
                                                     ^~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.

@kakshay21
Copy link
Contributor Author

@nathanielmanistaatgoogle Is it not required one?

@AspirinSJL AspirinSJL added release notes: no Indicates if PR should not be in release notes kokoro:force-run labels Jan 24, 2019
@AspirinSJL
Copy link
Member

Please fix the sanity check by running tools/distrib/clang_format_code.sh

@kakshay21
Fix warning
564be99 
Fix clang format
@kakshay21
Copy link
Contributor Author

@AspirinSJL can you run the tests again?

@AspirinSJL AspirinSJL merged commit 6c54391 into grpc:master Jan 27, 2019
@kakshay21 kakshay21 deleted the akshay-fix-warning branch January 27, 2019 05:12
@lock lock bot locked as resolved and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AspirinSJL AspirinSJL AspirinSJL approved these changes

Assignees

@AspirinSJL AspirinSJL

Labels
release notes: no Indicates if PR should not be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kakshay21 @AspirinSJL @grpc-kokoro