Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a potential leak #1663

Merged
merged 1 commit into from
May 20, 2015
Merged

Fix a potential leak #1663

merged 1 commit into from
May 20, 2015

Conversation

yang-g
Copy link
Member

@yang-g yang-g commented May 19, 2015

split_tail does the optimization of direct copy if the length is small enough. In that case, the existing unref is a no-op and the original current_slice could be leaked. Unref the original slice instead.

@dklempner
Copy link
Contributor

LGTM

@yang-g
Copy link
Member Author

yang-g commented May 20, 2015

green

@ctiller
Copy link
Member

ctiller commented May 20, 2015

Fantastic catch

ctiller added a commit that referenced this pull request May 20, 2015
@ctiller
Merge pull request #1663 from yang-g/leak
aa253c3 
Fix a potential leak
@ctiller ctiller merged commit aa253c3 into grpc:master May 20, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Jan 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@dklempner dklempner

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yang-g @dklempner @ctiller @googlebot