Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to use the default instance. #16466

Merged
merged 1 commit into from
Aug 27, 2018
Merged

Switch to use the default instance. #16466

merged 1 commit into from
Aug 27, 2018

Conversation

adelez
Copy link
Contributor

@adelez adelez commented Aug 27, 2018

No description provided.

@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link 

[trickle] No significant performance differences

@grpc-testing
Copy link 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,954,464      Total (=)      1,954,464

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,842,339      Total (>)     10,842,335

 No significant differences in binary sizes

@grpc-testing
Copy link 

[microbenchmarks] No significant performance differences

@adelez adelez merged commit c1a7cb4 into grpc:master Aug 27, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Nov 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@billfeng327 billfeng327 billfeng327 approved these changes

@nicolasnoble nicolasnoble Awaiting requested review from nicolasnoble

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adelez @grpc-testing @billfeng327