Add subprocess GPR API #1617
Merged
Add subprocess GPR API #1617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Port fling_test to it. This will be used to: - port remaining tests to Windows - enable testing what happens when servers or clients mysteriously disappear
| typedef struct gpr_subprocess gpr_subprocess; | ||
|
|
||
| /* .exe on windows, empty on unices */ | ||
| char *gpr_subprocess_binary_extension(); |
There was a problem hiding this comment.
I think you mean to use that function somewhere.
There was a problem hiding this comment.
I think that this should be changed to return a const char *. I'm happy to do a PR.
There was a problem hiding this comment.
I think you're right. If you want to fix it, feel free. I'm hoping to be
back to operating normally tomorrow.
On Mon, May 18, 2015, 4:45 PM jboeuf notifications@github.com wrote:
In include/grpc/support/subprocess.h
#1617 (comment):
- * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- /
+
+#ifndef GRPC_SUPPORT_SUBPROCESS_H
+#define GRPC_SUPPORT_SUBPROCESS_H
+
+typedef struct gpr_subprocess gpr_subprocess;
+
+/ .exe on windows, empty on unices */
+char *gpr_subprocess_binary_extension();I think that this should be changed to return a const char *. I'm happy
to do a PR.—
Reply to this email directly or view it on GitHub
https://github.com/grpc/grpc/pull/1617/files#r30557964.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port fling_test to it.
This will be used to: