Even More Clang Tidy: performance-* #15681

ncteisen · 2018-06-08T06:11:06Z

~~Built on #15680.~~

Working towards #14085.

Enables all performance-* checks and makes them pass. Most were done automatically, the second commit was done manually

grpc-testing · 2018-06-08T06:16:03Z

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE                                                          FILE SIZE
 ++++++++++++++ GROWING                                            ++++++++++++++

 -------------- SHRINKING                                          --------------
  -1.2%    -407 src/cpp/server/server_cc.cc                           -407  -1.2%
     -12.2%    -218 grpc::Server::Server                                  -218 -12.2%
     -11.3%    -183 grpc::Server::SyncRequestThreadManager::DoWork        -183 -11.3%
      -1.5%      -6 [Unmapped]                                              -6  -1.5%

 -+-+-+-+-+-+-+ MIXED                                              +-+-+-+-+-+-+-
  +0.0%     +11 [None]                                             -4.90Ki  -0.1%

  -0.1%    -396 TOTAL                                              -5.30Ki  -0.1%

grpc-testing · 2018-06-08T06:22:14Z

[trickle] No significant performance differences

grpc-testing · 2018-06-08T07:07:32Z

[microbenchmarks] Performance differences noted:
Benchmark                                                                                 cpu_time    real_time
----------------------------------------------------------------------------------------  ----------  -----------
BM_PumpStreamClientToServer<InProcess>/262144                                             -8%         -8%
BM_PumpStreamServerToClient<InProcess>/32768                                              -5%         -5%
BM_StreamingPingPong<MinInProcess, NoOpMutator, NoOpMutator>/262144/1                     +4%         +4%
BM_StreamingPingPong<MinInProcess, NoOpMutator, NoOpMutator>/262144/2                     +4%         +4%
BM_StreamingPingPongMsgs<InProcess, NoOpMutator, NoOpMutator>/32768                       +7%         +7%
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator, NoOpMutator>/262144/2/1     +7%         +7%
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator, NoOpMutator>/262144/1/0  +4%         +4%
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator, NoOpMutator>/262144/2/1  +9%         +9%
BM_UnaryPingPong<InProcess, NoOpMutator, NoOpMutator>/0/262144                            -4%         -4%
BM_UnaryPingPong<MinInProcess, NoOpMutator, NoOpMutator>/0/2097152                        -4%         -4%

grpc-testing · 2018-06-08T07:28:25Z

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE                                                          FILE SIZE
 ++++++++++++++ GROWING                                            ++++++++++++++

 -------------- SHRINKING                                          --------------
  -1.2%    -407 src/cpp/server/server_cc.cc                           -407  -1.2%
     -12.2%    -218 grpc::Server::Server                                  -218 -12.2%
     -11.3%    -183 grpc::Server::SyncRequestThreadManager::DoWork        -183 -11.3%
      -1.5%      -6 [Unmapped]                                              -6  -1.5%

 -+-+-+-+-+-+-+ MIXED                                              +-+-+-+-+-+-+-
  +0.0%     +11 [None]                                             -4.90Ki  -0.1%

  -0.1%    -396 TOTAL                                              -5.30Ki  -0.1%

grpc-testing · 2018-06-08T07:35:57Z

[trickle] No significant performance differences

grpc-testing · 2018-06-08T08:09:16Z

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE                                                          FILE SIZE
 ++++++++++++++ GROWING                                            ++++++++++++++

 -------------- SHRINKING                                          --------------
  -1.2%    -407 src/cpp/server/server_cc.cc                           -407  -1.2%
     -12.2%    -218 grpc::Server::Server                                  -218 -12.2%
     -11.3%    -183 grpc::Server::SyncRequestThreadManager::DoWork        -183 -11.3%
      -1.5%      -6 [Unmapped]                                              -6  -1.5%

 -+-+-+-+-+-+-+ MIXED                                              +-+-+-+-+-+-+-
  +0.0%     +11 [None]                                             -4.90Ki  -0.1%

  -0.1%    -396 TOTAL                                              -5.30Ki  -0.1%

grpc-testing · 2018-06-08T08:16:56Z

[trickle] No significant performance differences

grpc-testing · 2018-06-08T08:20:34Z

[microbenchmarks] Performance differences noted:
Benchmark                                                                              cpu_time    real_time
-------------------------------------------------------------------------------------  ----------  -----------
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator, NoOpMutator>/262144/1/1  +6%         +6%
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator, NoOpMutator>/262144/2/0  +4%         +4%
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator, NoOpMutator>/262144/2/1  +4%         +4%

grpc-testing · 2018-06-08T09:00:36Z

[microbenchmarks] Performance differences noted:
Benchmark                                                                                 cpu_time    real_time
----------------------------------------------------------------------------------------  ----------  -----------
BM_PumpStreamServerToClient<InProcess>/262144                                             -8%         -8%
BM_StreamingPingPongMsgs<MinInProcess, NoOpMutator, NoOpMutator>/262144                   +8%         +8%
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator, NoOpMutator>/262144/2/1  +6%         +6%
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator, NoOpMutator>/32768/2/1   +4%         +4%

grpc-testing · 2018-06-08T15:19:52Z

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE                                                          FILE SIZE
 ++++++++++++++ GROWING                                            ++++++++++++++

 -------------- SHRINKING                                          --------------
  -1.2%    -407 src/cpp/server/server_cc.cc                           -407  -1.2%
     -12.2%    -218 grpc::Server::Server                                  -218 -12.2%
     -11.3%    -183 grpc::Server::SyncRequestThreadManager::DoWork        -183 -11.3%
      -1.5%      -6 [Unmapped]                                              -6  -1.5%

 -+-+-+-+-+-+-+ MIXED                                              +-+-+-+-+-+-+-
  +0.0%     +11 [None]                                             -4.90Ki  -0.1%

  -0.1%    -396 TOTAL                                              -5.30Ki  -0.1%

grpc-testing · 2018-06-08T15:25:59Z

[trickle] No significant performance differences

grpc-testing · 2018-06-08T15:49:33Z

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE                                                          FILE SIZE
 ++++++++++++++ GROWING                                            ++++++++++++++

 -------------- SHRINKING                                          --------------
  -1.2%    -407 src/cpp/server/server_cc.cc                           -407  -1.2%
     -12.2%    -218 grpc::Server::Server                                  -218 -12.2%
     -11.3%    -183 grpc::Server::SyncRequestThreadManager::DoWork        -183 -11.3%
      -1.5%      -6 [Unmapped]                                              -6  -1.5%

 -+-+-+-+-+-+-+ MIXED                                              +-+-+-+-+-+-+-
  +0.0%     +11 [None]                                             -4.90Ki  -0.1%

  -0.1%    -396 TOTAL                                              -5.30Ki  -0.1%

grpc-testing · 2018-06-08T15:56:01Z

[trickle] No significant performance differences

grpc-testing · 2018-06-08T16:08:21Z

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE                                                          FILE SIZE
 ++++++++++++++ GROWING                                            ++++++++++++++

 -------------- SHRINKING                                          --------------
  -1.2%    -407 src/cpp/server/server_cc.cc                           -407  -1.2%
     -12.2%    -218 grpc::Server::Server                                  -218 -12.2%
     -11.3%    -183 grpc::Server::SyncRequestThreadManager::DoWork        -183 -11.3%
      -1.5%      -6 [Unmapped]                                              -6  -1.5%

 -+-+-+-+-+-+-+ MIXED                                              +-+-+-+-+-+-+-
  +0.0%     +11 [None]                                             -4.90Ki  -0.1%

  -0.1%    -396 TOTAL                                              -5.30Ki  -0.1%

grpc-testing · 2018-06-08T16:11:36Z

[microbenchmarks] No significant performance differences

grpc-testing · 2018-06-08T16:17:28Z

[trickle] No significant performance differences

grpc-testing · 2018-06-08T16:40:54Z

[microbenchmarks] Performance differences noted:
Benchmark                                                                cpu_time    real_time
-----------------------------------------------------------------------  ----------  -----------
BM_PumpStreamClientToServer<InProcess>/262144                            +5%         +5%
BM_StreamingPingPong<MinInProcess, NoOpMutator, NoOpMutator>/262144/2    -4%         -4%
BM_StreamingPingPongMsgs<MinInProcess, NoOpMutator, NoOpMutator>/262144  -4%         -4%
BM_StreamingPingPongMsgs<MinInProcess, NoOpMutator, NoOpMutator>/32768   -5%         -5%
BM_UnaryPingPong<InProcess, NoOpMutator, NoOpMutator>/0/2097152          +4%         +4%
BM_UnaryPingPong<InProcess, NoOpMutator, NoOpMutator>/262144/262144      +5%         +5%
BM_UnaryPingPong<InProcess, NoOpMutator, NoOpMutator>/32768/32768        +4%         +4%
BM_UnaryPingPong<MinInProcess, NoOpMutator, NoOpMutator>/0/2097152       +8%         +8%

grpc-testing · 2018-06-08T17:00:29Z

[microbenchmarks] No significant performance differences

ncteisen · 2018-06-11T14:31:54Z

Tests are green, ready for review

grpc-testing · 2018-06-11T23:37:41Z

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE                                                          FILE SIZE
 ++++++++++++++ GROWING                                            ++++++++++++++

 -------------- SHRINKING                                          --------------
  -0.0%     -21 [None]                                             -4.86Ki  -0.1%
  -1.2%    -407 src/cpp/server/server_cc.cc                           -407  -1.2%
     -12.2%    -218 grpc::Server::Server                                  -218 -12.2%
     -11.3%    -183 grpc::Server::SyncRequestThreadManager::DoWork        -183 -11.3%
      -1.5%      -6 [Unmapped]                                              -6  -1.5%

  -0.1%    -428 TOTAL                                              -5.26Ki  -0.1%

ncteisen · 2018-06-11T23:37:50Z

Rebased to merge together manual changes

grpc-testing · 2018-06-11T23:39:21Z

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE                                                          FILE SIZE
 ++++++++++++++ GROWING                                            ++++++++++++++

 -------------- SHRINKING                                          --------------
  -0.0%     -21 [None]                                             -4.86Ki  -0.1%
  -1.2%    -407 src/cpp/server/server_cc.cc                           -407  -1.2%
     -12.2%    -218 grpc::Server::Server                                  -218 -12.2%
     -11.3%    -183 grpc::Server::SyncRequestThreadManager::DoWork        -183 -11.3%
      -1.5%      -6 [Unmapped]                                              -6  -1.5%

  -0.1%    -428 TOTAL                                              -5.26Ki  -0.1%

grpc-testing · 2018-06-11T23:45:51Z

[trickle] No significant performance differences

grpc-testing · 2018-06-11T23:47:18Z

[trickle] No significant performance differences

grpc-testing · 2018-06-12T00:29:28Z

[microbenchmarks] No significant performance differences

grpc-testing · 2018-06-12T00:31:03Z

[microbenchmarks] No significant performance differences

grpc-testing · 2018-06-14T06:18:58Z

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE                                                          FILE SIZE
 ++++++++++++++ GROWING                                            ++++++++++++++

 -------------- SHRINKING                                          --------------
  -0.0%     -21 [None]                                             -4.86Ki  -0.1%
  -1.2%    -407 src/cpp/server/server_cc.cc                           -407  -1.2%
     -12.2%    -218 grpc::Server::Server                                  -218 -12.2%
     -11.3%    -183 grpc::Server::SyncRequestThreadManager::DoWork        -183 -11.3%
      -1.5%      -6 [Unmapped]                                              -6  -1.5%

  -0.1%    -428 TOTAL                                              -5.26Ki  -0.1%

grpc-testing · 2018-06-14T06:27:15Z

[trickle] No significant performance differences

grpc-testing · 2018-06-14T07:11:32Z

[microbenchmarks] No significant performance differences

ncteisen · 2018-06-14T14:33:29Z

Failures:

ncteisen · 2018-06-14T14:34:49Z

This PRs successor, #15684, has actual failure I am looking into. This one does not. Let's push forward and merge this one to make the investigation of the next one easier

grpc-testing · 2018-06-14T19:01:32Z

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE                                                          FILE SIZE
 ++++++++++++++ GROWING                                            ++++++++++++++

 -------------- SHRINKING                                          --------------
  -0.0%     -21 [None]                                             -4.86Ki  -0.1%
  -1.2%    -407 src/cpp/server/server_cc.cc                           -407  -1.2%
     -12.2%    -218 grpc::Server::Server                                  -218 -12.2%
     -11.3%    -183 grpc::Server::SyncRequestThreadManager::DoWork        -183 -11.3%
      -1.5%      -6 [Unmapped]                                              -6  -1.5%

  -0.1%    -428 TOTAL                                              -5.26Ki  -0.1%

grpc-testing · 2018-06-14T19:10:43Z

[trickle] No significant performance differences

grpc-testing · 2018-06-14T19:52:35Z

[microbenchmarks] Performance differences noted:
Benchmark                                                                              cpu_time    real_time
-------------------------------------------------------------------------------------  ----------  -----------
BM_PumpStreamServerToClient<InProcess>/262144                                          -11%        -11%
BM_StreamingPingPongMsgs<InProcess, NoOpMutator, NoOpMutator>/262144                   -6%         -6%
BM_StreamingPingPongMsgs<InProcess, NoOpMutator, NoOpMutator>/32768                    -7%         -7%
BM_StreamingPingPongMsgs<MinInProcess, NoOpMutator, NoOpMutator>/32768                 -8%         -8%
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator, NoOpMutator>/262144/1/1  -6%         -6%
BM_UnaryPingPong<InProcess, NoOpMutator, NoOpMutator>/0/262144                         +5%         +5%

ncteisen · 2018-06-15T14:43:46Z

#15029
#14245

ncteisen added kind/enhancement area/core priority/P3 labels Jun 8, 2018

ncteisen assigned vjpai Jun 8, 2018

ncteisen requested a review from vjpai June 8, 2018 06:11

ncteisen mentioned this pull request Jun 8, 2018

Más limpieza Clang #15684

Closed

ncteisen mentioned this pull request Jun 11, 2018

More Clang Tidy #15680

Merged

ncteisen force-pushed the even-more-clang branch from 33479dc to 2a40885 Compare June 11, 2018 23:36

ncteisen assigned markdroth and dgquintas Jun 14, 2018

ncteisen and others added 3 commits June 14, 2018 14:58

Enable the performance-* clang-tidy checks

58e0cbf

Manual fixes to enable performance- clang tidy checks

373fc6d

Add expception for util dir

8e75b48

ncteisen force-pushed the even-more-clang branch from 9bae85e to 8e75b48 Compare June 14, 2018 18:58

markdroth approved these changes Jun 15, 2018

View reviewed changes

ncteisen merged commit bd6ac0f into grpc:master Jun 15, 2018

ncteisen deleted the even-more-clang branch June 15, 2018 14:43

ncteisen added the release notes: no Indicates if PR should not be in release notes label Jul 19, 2018

lock bot locked as resolved and limited conversation to collaborators Oct 17, 2018

Even More Clang Tidy: performance-* #15681

Even More Clang Tidy: performance-* #15681

Conversation

ncteisen commented Jun 8, 2018 • edited Loading

grpc-testing commented Jun 8, 2018

grpc-testing commented Jun 8, 2018

grpc-testing commented Jun 8, 2018

grpc-testing commented Jun 8, 2018

grpc-testing commented Jun 8, 2018

grpc-testing commented Jun 8, 2018

grpc-testing commented Jun 8, 2018

grpc-testing commented Jun 8, 2018

grpc-testing commented Jun 8, 2018

grpc-testing commented Jun 8, 2018

grpc-testing commented Jun 8, 2018

grpc-testing commented Jun 8, 2018

grpc-testing commented Jun 8, 2018

grpc-testing commented Jun 8, 2018

grpc-testing commented Jun 8, 2018

grpc-testing commented Jun 8, 2018

grpc-testing commented Jun 8, 2018

grpc-testing commented Jun 8, 2018

ncteisen commented Jun 11, 2018

grpc-testing commented Jun 11, 2018

ncteisen commented Jun 11, 2018

grpc-testing commented Jun 11, 2018

grpc-testing commented Jun 11, 2018

grpc-testing commented Jun 11, 2018

grpc-testing commented Jun 12, 2018

grpc-testing commented Jun 12, 2018

grpc-testing commented Jun 14, 2018

grpc-testing commented Jun 14, 2018

grpc-testing commented Jun 14, 2018

ncteisen commented Jun 14, 2018

ncteisen commented Jun 14, 2018

grpc-testing commented Jun 14, 2018

grpc-testing commented Jun 14, 2018

grpc-testing commented Jun 14, 2018

ncteisen commented Jun 15, 2018

ncteisen commented Jun 8, 2018 •

edited

Loading