Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update health.proto to match grpc-proto reference copy #15252

Merged
merged 5 commits into from
May 4, 2018
Merged

Update health.proto to match grpc-proto reference copy #15252

merged 5 commits into from
May 4, 2018

Conversation

carl-mastrangelo
Copy link
Contributor

@nicolasnoble

Some other csharp changes were pulled in as a consequence of running the regeneration command.

@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link 

[trickle] No significant performance differences

@grpc-testing
Copy link 

[microbenchmarks] No significant performance differences

@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

1 similar comment
@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link 

[trickle] No significant performance differences

1 similar comment
@grpc-testing
Copy link 

[trickle] No significant performance differences

@grpc-testing
Copy link 

[microbenchmarks] No significant performance differences

1 similar comment
@grpc-testing
Copy link 

[microbenchmarks] No significant performance differences

@carl-mastrangelo
Copy link
Contributor Author

@yang-g would you be able to look as well?

yang-g
yang-g reviewed May 4, 2018
View reviewed changes
Copy link
Member

@yang-g yang-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The health.proto change lgtm

@yang-g
Copy link
Member

yang-g commented May 4, 2018

Test failure: #15199

@yang-g yang-g merged commit e84ea53 into grpc:master May 4, 2018
@carl-mastrangelo carl-mastrangelo deleted the healthy branch May 4, 2018 23:26
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yang-g yang-g yang-g approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carl-mastrangelo @grpc-testing @yang-g