Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding back nodejs version override support. #14714

Merged
merged 1 commit into from
Mar 14, 2018
Merged

Adding back nodejs version override support. #14714

merged 1 commit into from
Mar 14, 2018

Conversation

nicolasnoble
Copy link
Member

No description provided.

@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link 

[trickle] No significant performance differences

@nicolasnoble nicolasnoble merged commit 263d665 into grpc:master Mar 14, 2018
@grpc-testing
Copy link 

[microbenchmarks] No significant performance differences

@nicolasnoble nicolasnoble deleted the not-ALL-node branch March 14, 2018 23:44
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@murgatroid99 murgatroid99 murgatroid99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolasnoble @grpc-testing @murgatroid99