Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark tcp errors as UNAVAILABLE in UV tcp code #13917

Merged
merged 1 commit into from
Jan 5, 2018
Merged

Mark tcp errors as UNAVAILABLE in UV tcp code #13917

merged 1 commit into from
Jan 5, 2018

Conversation

murgatroid99
Copy link
Member

This does the same as #13771 as an attempt to deal with grpc/grpc-node#130 by making that status retryable.

@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link 

[trickle] No significant performance differences

@grpc-testing
Copy link 

[microbenchmarks] No significant performance differences

@murgatroid99
Copy link
Member Author

Restarting tests because of infrastructure error on a required test job

@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link 

[trickle] No significant performance differences

@grpc-testing
Copy link 

[microbenchmarks] No significant performance differences

@murgatroid99
Copy link
Member Author

Known failures: #13124, #13923, #13381, #11116, #13351, #12510.

@murgatroid99 murgatroid99 merged commit ca8650a into grpc:v1.8.x Jan 5, 2018
@apolcyn apolcyn mentioned this pull request Jan 5, 2018
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nicolasnoble nicolasnoble nicolasnoble approved these changes

Assignees

@nicolasnoble nicolasnoble

Labels
area/core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@murgatroid99 @grpc-testing @nicolasnoble @kokoro-team