Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Node interop test invocation to use new fixtures #13394

Merged
merged 1 commit into from
Nov 16, 2017
Merged

Update Node interop test invocation to use new fixtures #13394

merged 1 commit into from
Nov 16, 2017

Conversation

murgatroid99
Copy link
Member

@murgatroid99 murgatroid99 requested a review from adelez November 15, 2017 00:16
@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link 

[trickle] No significant performance differences

@murgatroid99
Copy link
Member Author

The interop cloud-to-cloud failure is a Node server failing because of #12932. But most of the tests against that server passed, which implies that this fix for the invocation of that server is working properly.

@grpc-testing
Copy link 

Corrupt JSON data (indicates timeout or crash): 
    bm_fullstack_unary_ping_pong.BM_UnaryPingPong_InProcessCHTTP2_NoOpMutator_Server_AddInitialMetadata_RandomAsciiMetadata_10__1___0_0.counters.new: 1


[microbenchmarks] No significant performance differences

@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link 

[trickle] No significant performance differences

@murgatroid99 murgatroid99 mentioned this pull request Nov 15, 2017
Closed
@grpc-testing
Copy link 

[microbenchmarks] No significant performance differences

@murgatroid99
Copy link
Member Author

Known failures: #13270, #13381, #12932, #13404, #13178, #13122.

The portability tests are failing due to a known issue. @nicolasnoble can you merge this as an admin?

@jtattermusch
Copy link
Contributor

I re-ran the portability linux test suite, it's possible to merge now. Merging.

@jtattermusch jtattermusch merged commit 57a6624 into grpc:master Nov 16, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adelez adelez adelez approved these changes

Assignees

@adelez adelez

Labels
area/interop lang/node
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@murgatroid99 @grpc-testing @jtattermusch @adelez @kokoro-team