Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused import of stats.proto #13390

Merged
merged 1 commit into from
Nov 14, 2017
Merged

Remove unused import of stats.proto #13390

merged 1 commit into from
Nov 14, 2017

Conversation

vjpai
Copy link
Member

@vjpai vjpai commented Nov 14, 2017

Was triggering a compiler info log indicating that it was unused

@vjpai vjpai requested a review from AspirinSJL November 14, 2017 20:10
@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link 

[trickle] No significant performance differences

@grpc-testing
Copy link 

[microbenchmarks] No significant performance differences

@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link 

[trickle] No significant performance differences

@grpc-testing
Copy link 

[microbenchmarks] No significant performance differences

@vjpai vjpai merged commit 0d5e24d into grpc:master Nov 14, 2017
@vjpai vjpai deleted the stats-proto branch November 14, 2017 23:43
@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AspirinSJL AspirinSJL AspirinSJL approved these changes

Assignees

@AspirinSJL AspirinSJL

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vjpai @grpc-testing @AspirinSJL