Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce bloat_diff #12832

Merged
merged 4 commits into from
Oct 4, 2017
Merged

Introduce bloat_diff #12832

merged 4 commits into from
Oct 4, 2017

Conversation

ctiller
Copy link
Member

@ctiller ctiller commented Oct 4, 2017

No description provided.

@ctiller ctiller requested review from ncteisen and matt-kwong October 4, 2017 21:21
matt-kwong
matt-kwong approved these changes Oct 4, 2017
View reviewed changes
Copy link
Contributor

@matt-kwong matt-kwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming the comment comes out correctly

optional: if you think people might run this locally, it might be nice to make commenting on PRs a flag

@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@ctiller ctiller merged commit 073404a into grpc:master Oct 4, 2017
@grpc-testing
Copy link 

[trickle] No significant performance differences

@grpc-testing
Copy link 

[microbenchmarks] No significant performance differences

@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matt-kwong matt-kwong matt-kwong approved these changes

@ncteisen ncteisen ncteisen approved these changes

Assignees

@ncteisen ncteisen

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ctiller @grpc-testing @ncteisen @matt-kwong @googlebot