-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ruby client utility for extracting Google::Rpc::Status from GRPC::Status #12452
Conversation
|
Thanks for the heads up, @apolcyn ! |
|
23e8a9d
to
6c8ccc1
Compare
PTAL
IMO the most tricky part of this was the added dependency on |
1cf8e92
to
f9d0447
Compare
FYI @qingling128 Any update on this PR, which is blocking the fix for googleapis/google-cloud-ruby#1438? |
Thanks for checking @geigerj ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just make sure to open an issue to (eventually) add the corresponding server-side code.
status from a grpc::Status
f9d0447
to
a594ba0
Compare
squashing commits down before mering |
mac tests saw pre-existing #12538, but sanity tests failed to build the docker image, so re-running sanity |
interop tests passed but the test failed because of
mac tests on failed with known kokoro/mac/ruby issue: #12538 |
…ruby Backport #12452 to 1.6.x
cc @geigerj @qingling128
Looking for feedback on this right now.