Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't test built artifacts on 1.3.x #11408

Merged
merged 1 commit into from
Jun 5, 2017
Merged

Don't test built artifacts on 1.3.x #11408

merged 1 commit into from
Jun 5, 2017

Conversation

murgatroid99
Copy link
Member

I had to do the same thing on 1.4.x, and now this is causing problems on 1.3.x too. See #11354.

@murgatroid99 murgatroid99 requested a review from dgquintas June 5, 2017 17:13
@grpc-kokoro
Copy link 

Performance differences noted:
Benchmark                                      cpu_time    real_time
-------------------------------------------  ----------  -----------
BM_MetadataFromInternedSlicesAlreadyInIndex       -8.50        -8.50

@murgatroid99
Copy link
Member Author

The Linux failures are #11008. The Mac tests actually passed. And the UBsan tests don't run on 1.3.x.

@murgatroid99 murgatroid99 merged commit 28aee69 into grpc:v1.3.x Jun 5, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 23, 2019
@lock lock bot unassigned dgquintas Jan 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dgquintas dgquintas dgquintas approved these changes

Assignees
No one assigned
Labels
area/build cla: yes lang/node
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@murgatroid99 @grpc-kokoro @dgquintas @googlebot