Will wait from travis, but basically LGTM. I wonder if there isn't a better way to detect the presence of nullptr tho...

I think that the best way to detect nullptr would be to actually have a
test run at configure time to see if the nullptr inherently exists and has
normal behavior.

On Wed, Mar 25, 2015 at 3:16 PM Nicolas Noble notifications@github.com
wrote:

Will wait from travis, but basically LGTM. I wonder if there isn't a
better way to detect the presence of nullptr tho...

—
Reply to this email directly or view it on GitHub
#1135 (comment).

Is it possible to add a test to build with some legacy compiler?

On Wed, Mar 25, 2015 at 3:33 PM, Vijay Pai notifications@github.com wrote:

I think that the best way to detect nullptr would be to actually have a
test run at configure time to see if the nullptr inherently exists and has
normal behavior.

On Wed, Mar 25, 2015 at 3:16 PM Nicolas Noble notifications@github.com
wrote:

Will wait from travis, but basically LGTM. I wonder if there isn't a
better way to detect the presence of nullptr tho...

—
Reply to this email directly or view it on GitHub
#1135 (comment).

—
Reply to this email directly or view it on GitHub
#1135 (comment).

That would be great; maybe there is a way to do it in Travis? I'm using an outside account that has an old compiler on it for now.

I'm trying something - travis has that ability, but we can't compile and run the tests, since they're still containing things gcc-4.4 wouldn't like.

That's correct, we can only run a limited selection of the C++ tests under
4.4

On Wed, Mar 25, 2015 at 4:27 PM Nicolas Noble notifications@github.com
wrote:

I'm trying something - travis has that ability, but we can't compile and
run the tests, since they're still containing things gcc-4.4 wouldn't like.

—
Reply to this email directly or view it on GitHub
#1135 (comment).

Check vjpai#1 - I've done a pull request on top of that pull request :-)

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

I confirm that all your commits are belong to me

On Wed, Mar 25, 2015 at 5:44 PM googlebot notifications@github.com wrote:

We found a Contributor License Agreement for you (the sender of this pull
request) and all commit authors, but as best as we can tell these commits
were authored by someone else. If that's the case, please add them to this
pull request and have them confirm that they're okay with these commits
being contributed to Google. If we're mistaken and you did author these
commits, just reply here to confirm.

—
Reply to this email directly or view it on GitHub
#1135 (comment).

Yeah, yeah, I consent :-)

FYI, clang has a test to check if nullptr is supported using __has_features . For gcc, we can test based on the version # . So, I should add a test in for the clang case also.