Fix server crash if host header field is translated to :authority #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we missed the fact that we have to increment reference count when passing grpc_mdstr to grpc_mdelem_from_metadata_strings, which leads to crash. This commit fixes this issue.
|
This looks right to me -- I missed this in review because I was too focused on setup/teardown refcount correctness in the previous PR. |
dklempner
added a commit
that referenced
this pull request
Mar 27, 2015
…field Fix server crash if host header field is translated to :authority
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we missed the fact that we have to increment reference
count when passing grpc_mdstr to grpc_mdelem_from_metadata_strings,
which leads to crash. This commit fixes this issue.