Adding the ability to specify a service namespace on protoc's command line. #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… line. Usage example: protoc ... --grpc_out=services_namespace=xyz:./path/to/output/dir ... This is difficult to add a test for this without significantly changing all of the examples, or the build system. However this has been successfully tested locally.
| if (!parameter.empty()) { | ||
| std::vector<grpc::string> parameters_list = | ||
| grpc_generator::tokenize(parameter, ","); | ||
| for (auto ¶meter_string: parameters_list) { |
There was a problem hiding this comment.
Vijay seems to be removing all range based loops, does it apply to the code generators?
There was a problem hiding this comment.
I'll remove this one, yes.
|
Friendly ping. |
yang-g
added a commit
that referenced
this pull request
Mar 26, 2015
Adding the ability to specify a service namespace on protoc's command line.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage example: protoc ... --grpc_out=services_namespace=xyz:./path/to/output/dir ...
This is difficult to add a test for this without significantly changing all of the examples, or the build system. However this has been successfully tested locally.