Make Python package spec indirect #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soltanmm
force-pushed
the
internal-codegen-support-s2
branch
2 times, most recently
from
3060a6e to
f01af6b
Compare
This is part of a change to ease internal usage of GRPC.
soltanmm
force-pushed
the
internal-codegen-support-s2
branch
from
f01af6b to
3bb5215
Compare
|
LGTM but I'd like a C++ reviewer to also have a look. @nicolasnoble, please review and merge? |
| using google::protobuf::io::Printer; | ||
| using google::protobuf::io::StringOutputStream; | ||
| using google::protobuf::io::ZeroCopyOutputStream; |
There was a problem hiding this comment.
It's fine for now, but we should use the compiler/config.h file to use grpc::protobuf instead. For a future PR that is.
nicolasnoble
added a commit
that referenced
this pull request
Mar 19, 2015
Make Python package spec indirect
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nathanielmanistaatgoogle Please review and merge!