Add logging of flow control variables, (mostly) fix flow control #10720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added a small tweak to how eagerly we initiate writes, which seems to improve our trickle benchmarks significantly. |
… bloat spiral of death)
ctiller
changed the title
|
I ran a bm_diff on trickle manually (since it doesn't usually run... since it takes a looooong time) |
|
(take note of that svr_stream_stalls_per_iteration column!) |
|
|
|
Jenkins: test this please |
vjpai
previously requested changes
Apr 21, 2017
vjpai
reviewed
Apr 21, 2017
| /* for each grpc_chttp2_stream that's become writable, frame it's data | ||
| (according to available window sizes) and add to the output buffer */ | ||
| while (grpc_chttp2_list_pop_writable_stream(t, &s)) { | ||
| while (true) { | ||
| if (t->outbuf.length > 1024 * 1024) { |
There was a problem hiding this comment.
Since this will eventually be a tuned parameter, how about at least making it a #define or something now so that it's identifiable in the future?
|
ncteisen
approved these changes
May 5, 2017
|
Jenkins: test this please |
|
Failures seem in line with master... merging |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.