Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.3.x upmerge #10661

Merged
merged 2 commits into from
Apr 14, 2017
Merged

1.3.x upmerge #10661

merged 2 commits into from
Apr 14, 2017
+5 −5

Conversation

ctiller
Copy link
Member

@ctiller ctiller commented Apr 14, 2017

No description provided.

ctiller added 2 commits April 13, 2017 14:25
@ctiller
In all cases when writing, respect what the peer has asked for (not w…
6814d07 
…hat the peer has acknowledged we asked for)
@ctiller
Merge pull request #10641 from ctiller/truebin
bb75f3e 
In all cases when writing, respect what the peer has asked for
@ctiller ctiller requested a review from sreecha April 14, 2017 15:14
@grpc-kokoro
Copy link 

Performance differences noted:
Benchmark                     cpu_time    real_time
--------------------------  ----------  -----------
BM_TransportStreamRecv/0       -117.50      -117.50
BM_TransportStreamRecv/4k      -108.00      -108.00
BM_TransportStreamRecv/512     -120.00      -120.00
BM_TransportStreamRecv/64      -109.00      -109.00

@ctiller ctiller merged commit e412a18 into master Apr 14, 2017
@markdroth markdroth mentioned this pull request May 18, 2017
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jan 23, 2019
@lock lock bot unassigned sreecha Jan 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sreecha sreecha sreecha approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ctiller @grpc-kokoro @sreecha @googlebot