Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In all cases when writing, respect what the peer has asked for #10641

Merged
merged 1 commit into from
Apr 14, 2017
Merged

In all cases when writing, respect what the peer has asked for #10641

merged 1 commit into from
Apr 14, 2017

Conversation

ctiller
Copy link
Member

@ctiller ctiller commented Apr 13, 2017 •
edited
Loading

(not what the peer has acknowledged we asked for)

Fixes #10640

@ctiller ctiller requested a review from vjpai April 13, 2017 21:28
vjpai
vjpai approved these changes Apr 13, 2017
View reviewed changes
Copy link
Member

@vjpai vjpai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vjpai vjpai mentioned this pull request Apr 13, 2017
Merged
@ctiller
Copy link
Member Author

ctiller commented Apr 13, 2017

@dgquintas - let me know if I should retarget for 1.3

@dgquintas
Copy link
Contributor

@ctiller Please do. The branch has now been created: https://github.com/grpc/grpc/tree/v1.3.x

@grpc-kokoro
Copy link 

Performance differences noted:
Benchmark                                                                     cpu_time    real_time
--------------------------------------------------------------------------  ----------  -----------
BM_HpackEncoderEncodeHeader<SingleInternedBinaryElem<100, true>>/0/16k          +12.00       +12.00
BM_HpackEncoderEncodeHeader<SingleNonInternedBinaryElem<1, true>>/0/16k         +23.50       +23.50
BM_HpackEncoderEncodeHeader<SingleNonInternedBinaryElem<10, true>>/0/16k        +22.00       +22.00
BM_HpackEncoderEncodeHeader<SingleNonInternedBinaryElem<100, false>>/0/16k     +104.00      +104.00
BM_HpackEncoderEncodeHeader<SingleNonInternedBinaryElem<100, true>>/0/16k       +22.50       +22.50
BM_HpackEncoderEncodeHeader<SingleNonInternedBinaryElem<3, true>>/0/16k         +21.00       +21.00
BM_HpackEncoderEncodeHeader<SingleNonInternedBinaryElem<31, true>>/0/16k        +22.50       +22.50
BM_HpackParserParseHeader<RepresentativeClientInitialMetadata>                  -26.50       -26.50

@ctiller ctiller changed the base branch from master to v1.3.x April 13, 2017 23:40
@ctiller
Copy link
Member Author

ctiller commented Apr 13, 2017

Jenkins: test this please

@grpc-kokoro
Copy link 

No significant performance differences

@ctiller
Copy link
Member Author

ctiller commented Apr 14, 2017

Failed: #10576 #10659

@ctiller ctiller merged commit bb75f3e into grpc:v1.3.x Apr 14, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 23, 2019
lidizheng pushed a commit to lidizheng/grpc that referenced this pull request Feb 12, 2021
On demand loading of ScopedRouteConfiguration (grpc#12640)
21ede2c 
Add a field to the current protobuf of ScopedRouteConfiguration to enable on demand scoped route table loading. The on demand scope route tables will be loaded lazily. The lazy loading feature of route table associated with scope is achieved by extending the current vhds on_demand filter to support lazy loading of RouteConfigurationscoped route discovery service.If a scoped route configuration is set to be loaded lazily, upon a http request using SRDS, when the corresponding route table of a scope is not found, post a callback to control plane, request the route table from the management server, after the route table has been initialized, continue the filter chain.

https://docs.google.com/document/d/15GX30U5CH2bsWUyQRkiiQ_nbMCoklvgP_ObrDaSlkuc/edit?usp=sharing

Risk Level: Low
Testing: add unit tests and integration test to verifiy behavior changes

Fixes grpc#10641

Signed-off-by: chaoqinli <chaoqinli@google.com>

Mirrored from https://github.com/envoyproxy/envoy @ 709d1c31749a6ba2eab2865927f10300570ac533
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vjpai vjpai vjpai approved these changes

Assignees

@vjpai vjpai

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ctiller @dgquintas @grpc-kokoro @vjpai @googlebot