Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ubsan fixes #10630

Merged
merged 1 commit into from
Apr 14, 2017
Merged

ubsan fixes #10630

merged 1 commit into from
Apr 14, 2017

Conversation

ctiller
Copy link
Member

@ctiller ctiller commented Apr 13, 2017

No description provided.

@ctiller ctiller requested a review from dgquintas April 13, 2017 14:59
@grpc-kokoro
Copy link 

Performance differences noted:
Benchmark                                                   cpu_time    real_time
--------------------------------------------------------  ----------  -----------
BM_HpackParserInitDestroy                                   -1002.00     -1001.50
BM_HpackParserParseHeader<NonIndexedBinaryElem<1, true>>      +39.00       +39.00
BM_Zalloc/4k                                                  -26.00       -26.00

dgquintas
dgquintas approved these changes Apr 14, 2017
View reviewed changes
src/core/ext/census/resource.c
@@ -223,7 +223,9 @@ size_t allocate_resource(void) {
if (n_resources == n_defined_resources) {
size_t new_n_resources = n_resources ? n_resources * 2 : 2;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while you are here, could you make the test over n_resources be ... n_resources != 0 ? ...?

@ctiller ctiller merged commit a6ede89 into grpc:master Apr 14, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 23, 2019
@lock lock bot unassigned dgquintas Jan 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dgquintas dgquintas dgquintas approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ctiller @grpc-kokoro @dgquintas @googlebot