Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check that we don't schedule the same closure twice at once. #10475

Merged
merged 1 commit into from
Apr 13, 2017
Merged

Add check that we don't schedule the same closure twice at once. #10475

merged 1 commit into from
Apr 13, 2017

Conversation

markdroth
Copy link
Member

For debug builds only.

@markdroth markdroth requested a review from ctiller April 4, 2017 23:36
@grpc-kokoro
Copy link 

Performance differences noted:
Benchmark                                allocs_per_iteration    atm_add_per_iteration    atm_cas_per_iteration      cpu_time  locks_per_iteration      real_time  writes_per_iteration
---------------------------------------  ----------------------  -----------------------  -----------------------  ----------  ---------------------  -----------  ----------------------
BM_IsolatedFilter<CompressFilter, NoOp>                                                                                 -8.00                               -8.00
BM_IsolatedFilter<NoFilter, NoOp>                                                                                       -5.50                               -5.50

@markdroth
Copy link
Member Author

Amazingly, it looks like this didn't actually detect any bugs in our existing tests. But I think it's still a nice thing to have.

@markdroth markdroth merged commit e98cf24 into grpc:master Apr 13, 2017
@markdroth markdroth deleted the closure_debug_schedule_check branch April 13, 2017 22:05
@lock lock bot locked as resolved and limited conversation to collaborators Jan 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ctiller ctiller ctiller approved these changes

Assignees

@ctiller ctiller

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@markdroth @grpc-kokoro @ctiller @googlebot