Fix call destruction bug #10468
Merged
Fix call destruction bug #10468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasnoble
reviewed
Apr 4, 2017
src/node/ext/call.cc
Outdated
| @@ -521,6 +523,7 @@ Call::Call(grpc_call *call) : wrapped_call(call), | |||
| Call::~Call() { | |||
| if (wrapped_call != NULL) { | |||
There was a problem hiding this comment.
Since that code is duplicated into line 571, I'm usually more in favor of adding a "destroy" method that's containing the code in a unique manner, but called from the two locations. That way you can keep the if (wrapped_call != NULL) logic segregated into that specialized function.
|
The interop failure is #10455 and I can't tell what happened to the performance tests, but the Node performance tests passed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Node glue code has a mechanism to destroy a call after the last batch has completed. In some cases, the call could get garbage collected before its final batch completed, which would cause errors. This change fixes that by adding a
Persistentto the tag that keeps the JavaScript-level call object alive as long as it has a pending batch.