Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unref the tail, not the original slice #10459

Merged
merged 1 commit into from
Apr 5, 2017
Merged

Unref the tail, not the original slice #10459

merged 1 commit into from
Apr 5, 2017

Conversation

yang-g
Copy link
Member

@yang-g yang-g commented Apr 4, 2017

If the length of tail is short, the tail slice may be an inlined copy. Unreffing the original slice in this case will cause memory corruption.

@yang-g yang-g requested a review from jboeuf April 4, 2017 17:06
@grpc-kokoro
Copy link 

No significant performance differences

@yang-g
Copy link
Member Author

yang-g commented Apr 5, 2017

Test failure #10481

@yang-g yang-g merged commit 4723b71 into grpc:master Apr 5, 2017
yang-g added a commit that referenced this pull request Apr 6, 2017
@yang-g
Merge pull request #10495 from yang-g/missing_tail
a568088 
Backport #10459 to v1.2.x
@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jboeuf jboeuf jboeuf approved these changes

Assignees

@jboeuf jboeuf

Labels
area/core area/security cla: yes kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yang-g @grpc-kokoro @jboeuf @googlebot