Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load Reporting back to using metadata #10391

Merged
merged 1 commit into from
Apr 17, 2017
Merged

Load Reporting back to using metadata #10391

merged 1 commit into from
Apr 17, 2017

Conversation

dgquintas
Copy link
Contributor

No description provided.

@dgquintas dgquintas requested a review from ctiller March 30, 2017 22:22
@grpc-kokoro
Copy link 

No significant performance differences

@ctiller
Copy link
Member

ctiller commented Apr 14, 2017

This needs a mechanism to include the load reporting filter or not.

@dgquintas
Copy link
Contributor Author

@ctiller at compile time? There's https://github.com/grpc/grpc/blob/master/src/core/ext/filters/load_reporting/load_reporting.c#L77 for runtime.

ctiller
ctiller previously approved these changes Apr 14, 2017
View reviewed changes
@ctiller ctiller dismissed their stale review April 14, 2017 22:12

hang on

ctiller
ctiller requested changes Apr 14, 2017
View reviewed changes
tools/codegen/core/gen_static_metadata.py Outdated
@@ -159,6 +160,7 @@
'user-agent',
'host',
'lb-token',
'lb-cost-bin',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be multivalued? If yes, it doesn't belong here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed. PTAL.

@dgquintas dgquintas force-pushed the lr_back_to_md branch 2 times, most recently from 619db9e to 08767f4 Compare April 15, 2017 00:59
@grpc-kokoro
Copy link 

No significant performance differences

@dgquintas
Copy link
Contributor Author

Issues: #10576 #9542

@ctiller can you PTAL?

@dgquintas
Copy link
Contributor Author

Issues: #9542 #10576

@dgquintas dgquintas merged commit a6f64f4 into grpc:master Apr 17, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ctiller ctiller ctiller approved these changes

Assignees

@ctiller ctiller

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dgquintas @grpc-kokoro @ctiller @googlebot