Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"make test_python" should be a thing that exists and runs Python tests. #276

Closed
nathanielmanistaatgoogle opened this issue Jan 29, 2015 · 4 comments
Closed

"make test_python" should be a thing that exists and runs Python tests. #276

nathanielmanistaatgoogle opened this issue Jan 29, 2015 · 4 comments
Assignees
@nicolasnoble
Labels
disposition/help wanted Maintainers do not have enough resources to allocate to this at the moment. Help is appreciated! lang/all wrapped languages lang/Python
Milestone
03/17 Weekly Wrap...

Comments

@nathanielmanistaatgoogle
Copy link
Member

It's acceptable only for the nonce that I've hacked up a few shell scripts that plug into run_tests.py; running Python tests should really be stated properly and doable from both make and run_tests (and the run_tests configuration should be parallelized).
@nathanielmanistaatgoogle nathanielmanistaatgoogle added disposition/help wanted Maintainers do not have enough resources to allocate to this at the moment. Help is appreciated! lang/Python labels Jan 29, 2015
@tbetbetbe tbetbetbe modified the milestones: Wrapped Languages Weekly 02/10, Wrapped Languages Weekly 02/17 Feb 12, 2015
Closed
@nathanielmanistaatgoogle
Copy link
Member Author

Nicolas, is this task worth doing or should it be closed with the reasoning being that run_tests.py is the only supported way of running Python tests?

@nicolasnoble
Copy link
Member

I'm actually fine saying the "test_python" target is a .PHONY one that just piggy-backs on run_tests.py - would that satisfy this ?

@nathanielmanistaatgoogle
Copy link
Member Author

Yes, I think that would be fine.

nicolasnoble added a commit to nicolasnoble/grpc that referenced this issue Mar 17, 2015
@nicolasnoble
Implements grpc#276
051a28f 
Adds a Makefile target called 'test_python' that first builds grpc, then call run_tests.py to run the python tests for the current configuration.
@nathanielmanistaatgoogle
Copy link
Member Author

This is fixed in #1070.

stanley-cheung pushed a commit to stanley-cheung/grpc that referenced this issue Aug 27, 2015
@ctiller
Merge pull request grpc#276 from yang-g/master
bcd57fc 
Update c++ examples to API changes.
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nicolasnoble nicolasnoble

Labels
disposition/help wanted Maintainers do not have enough resources to allocate to this at the moment. Help is appreciated! lang/all wrapped languages lang/Python
Projects
None yet
Milestone
03/17 Weekly Wrapped Languages
Development

No branches or pull requests
3 participants
@nicolasnoble @tbetbetbe @nathanielmanistaatgoogle