Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA-4388 Fixes in append scenario #5

Merged
merged 19 commits into from
Nov 13, 2023
Merged

QA-4388 Fixes in append scenario #5

merged 19 commits into from
Nov 13, 2023

Conversation

ahitrin
Copy link
Contributor

@ahitrin ahitrin commented Nov 9, 2023 •
edited
Loading

  1. Perform several operations in a single transaction.
  2. Use retries on some "legal" exceptions.
  3. Split complicated function into several smaller ones.

ahitrin added 19 commits November 7, 2023 16:52
@ahitrin
Micro: use case instead of if when choosing action
a82c287
@ahitrin
split long function into several smaller ones
dee5b6d
@ahitrin
More straightforward list creation
16d9ef3
@ahitrin
Mark args as unused
d5dbcdf
@ahitrin
Implement retries, attempt 1/10
77940f5
@ahitrin
Fix: avoid NumberFormatException on missing values
e0f32a7
@ahitrin
Raise max attempts to 20
c603fce
@ahitrin
Retry on replication timeout too
b943f2b
@ahitrin
format
341f4b9
@ahitrin
Replace selector fn with a simple map
bbf7e49
@ahitrin
Wait before retry
c437094
@ahitrin
Refresh comments
373dd71
@ahitrin
Fix catching order
4121d20
@ahitrin
Print table content at the end of the test
7add130
@ahitrin
Process exceptions in the same way, again
82a74b6
@ahitrin
Revert "Process exceptions in the same way, again"
b3e2763 
This reverts commit 82a74b6.
@ahitrin
TransactionException is just an info, okay
9cc413f
@ahitrin
Try to use a single transaction for all ops (no success yet)
a4979d3
@ahitrin
Fix: eagerly invoke transaction ops
643bd05
@ahitrin ahitrin changed the title QA-4388 QA-4388 Fixes in append scenario Nov 9, 2023
@ahitrin ahitrin marked this pull request as ready for review November 9, 2023 12:01
@ahitrin ahitrin requested review from iartiukhov and Berkof November 9, 2023 12:01
iartiukhov
iartiukhov approved these changes Nov 13, 2023
View reviewed changes
Copy link

@iartiukhov iartiukhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ahitrin ahitrin merged commit cde8440 into main Nov 13, 2023
@ahitrin ahitrin deleted the QA-4388 branch November 13, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iartiukhov iartiukhov iartiukhov approved these changes

@Berkof Berkof Awaiting requested review from Berkof

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahitrin @iartiukhov